[RFC] ditch support for linux <= 2.2 [was: Re: [patch] size optimization for mkswap.c]

[Rob Landley]

On Thursday 16 March 2006 8:46 pm, Bernhard Fischer wrote:
> On Thu, Mar 16, 2006 at 03:18:50PM -0500, Rob Landley wrote:
> >On Thursday 16 March 2006 9:06 am, Bernhard Fischer wrote:
> >> Forgot to mention these:
> >> >+config CONFIG_FEATURE_MKSWAP_V0
> >> >+	bool "  version 0 support"
> >> >+	default n
> >> >+	depends on CONFIG_MKSWAP
> >> >+#	depends on CONFIG_MKSWAP && CONFIG_DEPRECATED
> >>
> >> Should we add something like CONFIG_DEPRECATED for trunk (i.e. for 1.2)?
> >
> >Now that we have a Busybox Settings menu, we should add a menu of
> > deprecated stuff under it.  We probably don't need a separate deprecated
> > tag.
>
> So, do i get you right that we don't want an explicit CONFIG_DEPRECATED
> in the general config, but just ditch them from the code for 1.2?
>
> I, personally, don't need support for linux-2.0 (nor 2.2 for that
> matter), so i can live with this pretty well. If anyone disagrees, then
> please speak up now.

They can always create the swap file using mainstream tools.  (Or ancient 
versions thereof that match their kernel.)

> >The new swapfile format was introduced for the 2.2 kernel, which has now
> >fallen off the low-end of what we support.  If we support the -v flag at
> > all we should ignore it.
>
> vodz will most likely point out a way to just ignore it

Oh sure, put it in the argument string but never check that flag.  Easy, costs 
one byte.

> >I'd chop v0 support out entirely.  It's beyond deprecated, it's obsolete
> > (as far as busybox is concerned).
> >
> >> If v0 is disabled and the user requests it, then we could as well
> >> silently create a v1 style swap. By careful inspection, the user would
> >> notice the version anyway as it prints:
> >> Setting up swapspace version 1, size = xyz bytes
> >
> >We can just say "setting up swapspace", no need to even mention version. 
> > ext2 replaced the old ext, and SWAPSPACE2 has replaced the old kind. 
> > (And it's confusing that -v1 is SWAPSPACE2.  Let's not go there.)
>
> ok. Saves several bytes for the future trunk aka 1.2

Cool

Rob
-- 
Never bet against the cheap plastic solution.