[PATCH] su code clean up and new config option V.2
Tito
farmatito at tiscali.it
Sun Jul 9 10:28:49 PDT 2006
On Sunday 9 July 2006 15:51, Tito wrote:
Hi,
this is an improved version of the previous patch:
>1) removes an a lot of #ifdef's from su.c
>2) adds a new config option to enable/disable syslogging in su
> (it now loggs successes and failures!!!)
3) size is about the same as before with syslogging enabled.
4) fixes a potential issue with struct passwd *pw making old_user = opt_username (new_user)
With syslogging enabled:
function old new delta
su_main 485 493 +8
.rodata 1879 1875 -4
> With syslogging disabled:
> root at localhost:/dev/pts/2:/root/Desktop/busybox# make bloatcheck
> function old new delta
> .rodata 1879 1847 -32
> su_main 485 357 -128
> ------------------------------------------------------------------------------
> (add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-160) Total: -160 bytes
The patch is tested and works fine for me.
Please apply if you like it.
Ciao,
Tito
-------------- next part --------------
A non-text attachment was scrubbed...
Name: su_v2.patch
Type: text/x-diff
Size: 5124 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20060709/00bcf060/su_v2.bin
More information about the busybox
mailing list