[PATCH] su code clean up, minor size reduction and new config option

Tito farmatito at tiscali.it
Sun Jul 9 06:51:53 PDT 2006


Hi,
this patch:
1) removes an a lot of #ifdef's from su.c
2) adds a new config option to enable/disable syslogging in su
	(it now loggs successes and failures!!!)
3) reduces the size a little bit.

With syslogging enabled:
root at localhost:/dev/pts/2:/root/Desktop/busybox# make bloatcheck
  CC loginutils/su.o
  AR cru loginutils/loginutils.a
  LINK busybox_unstripped
function                                             old     new   delta
su_main                                              485     483      -2
.rodata                                             1879    1875      -4
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-6)               Total: -6 bytes


With syslogging disabled:
root at localhost:/dev/pts/2:/root/Desktop/busybox# make bloatcheck
function                                             old     new   delta
.rodata                                             1879    1847     -32
su_main                                              485     357    -128
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-160)           Total: -160 bytes

The patch is tested and works fine for me.
Please apply if you like it.

Ciao,
Tito
-------------- next part --------------
A non-text attachment was scrubbed...
Name: su.patch
Type: text/x-diff
Size: 5076 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20060709/bc12772f/su-0001.bin


More information about the busybox mailing list