[patch] WORDSIZE dependant printf length modifiers

Rob Landley rob at landley.net
Sat Apr 8 20:07:38 UTC 2006


On Saturday 08 April 2006 4:43 am, Robert P. J. Day wrote:
> On Fri, 7 Apr 2006, Rob Landley wrote:
> > I'm kind of resistant to using boolean data types.  I know java has
> > them, but in busybox they tend to either surprise people by being a
> > full int when they thought it was a bitfield,
>
> quite possibly but, if you're using an int to represent a boolean
> value, obviously you're paying for it, anyway.  i just mentioned it
> since both nfsmount.h and nfsmount.c use the "bool_t" data type and,
> as is my nature, i'm a big fan of consistency.

When did this start?  Rummages...  Ick.

I'm a big fan of consistency too.  I should remove this mess...

> and declaring boolean variables as some type of actual "boolean"
> definitely improves the code aesthetics and, possibly, type checking.

It somehow improves the code to use a type that has a profoundly undefined 
representation?

> anyway, it's your call.

I've never gone through and cleaned up nfsmount because I don't have an nfs 
test system, but it looks like I'm going to have to create one.

Not this week, though.

> rday

Rob
-- 
Never bet against the cheap plastic solution.



More information about the busybox mailing list