[git commit] docproc: avoid segfault during file closing

Denys Vlasenko vda.linux at googlemail.com
Sat Apr 13 15:57:46 UTC 2024


commit: https://git.busybox.net/busybox/commit/?id=681e4f5d922b9f0ea968238750d5c5d748eac809
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

In the function find_export_symbols, since the fopen file does not
exit when it fails, there is a dereference problem in fclose(fp),
which will cause a segmentation fault.

Signed-off-by: Yan Zhu <zhuyan2015 at foxmail.com>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 scripts/basic/docproc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/basic/docproc.c b/scripts/basic/docproc.c
index 4464e1874..8828901a1 100644
--- a/scripts/basic/docproc.c
+++ b/scripts/basic/docproc.c
@@ -180,6 +180,7 @@ void find_export_symbols(char * filename)
 		{
 			fprintf(stderr, "docproc: ");
 			perror(real_filename);
+			exit(1);
 		}
 		while (fgets(line, MAXLINESZ, fp)) {
 			unsigned char *p;


More information about the busybox-cvs mailing list