[git commit branch/1_27_stable] dpkg: fix CONFIG_FEATURE_CLEAN_UP handling

Denys Vlasenko vda.linux at googlemail.com
Tue Jul 18 17:20:58 UTC 2017


commit: https://git.busybox.net/busybox/commit/?id=80cb8796f86754faa1569994b9355eeffe0b7759
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/1_27_stable

dpkg moved to away from dynamically allocating the hashtables in commit
c87339d584 (dpkg: trivial code shrinkage, and redo G trick correctly) almost
ten years ago, but the cleanup code was never adjusted to match.

Glibc loudly complains about this:

*** Error in `dpkg': free(): invalid pointer: 0x0000007fac3478c0 ***

Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 archival/dpkg.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/archival/dpkg.c b/archival/dpkg.c
index 1cd45ed..da3b086 100644
--- a/archival/dpkg.c
+++ b/archival/dpkg.c
@@ -1938,10 +1938,6 @@ int dpkg_main(int argc UNUSED_PARAM, char **argv)
 		for (i = 0; i < STATUS_HASH_PRIME; i++) {
 			free(status_hashtable[i]);
 		}
-
-		free(status_hashtable);
-		free(package_hashtable);
-		free(name_hashtable);
 	}
 
 	return EXIT_SUCCESS;


More information about the busybox-cvs mailing list