[git commit] uudecode: fix buggy check for empty filename

Denys Vlasenko vda.linux at googlemail.com
Tue Oct 18 10:07:05 UTC 2011


commit: http://git.busybox.net/busybox/commit/?id=5f92043c3f9026725d518b6c76f7ef64cc8d4059
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 coreutils/uudecode.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/coreutils/uudecode.c b/coreutils/uudecode.c
index 6ecfe6c..23ff711 100644
--- a/coreutils/uudecode.c
+++ b/coreutils/uudecode.c
@@ -125,10 +125,11 @@ int uudecode_main(int argc UNUSED_PARAM, char **argv)
 		mode = bb_strtou(line_ptr, NULL, 8);
 		if (outname == NULL) {
 			outname = strchr(line_ptr, ' ');
-			if ((outname == NULL) || (*outname == '\0')) {
+			if (!outname)
 				break;
-			}
 			outname++;
+			if (!outname[0])
+				break;
 		}
 		dst_stream = stdout;
 		if (NOT_LONE_DASH(outname)) {


More information about the busybox-cvs mailing list