[BusyBox 0000468]: rmmod does not report failure

[bugs at busybox.net]

The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=468 
====================================================================== 
Reported By:                mbizon
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   468
Category:                   Kernel Module Support
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             10-04-2005 12:37 PDT
Last Modified:              12-14-2005 19:54 PST
====================================================================== 
Summary:                    rmmod does not report failure
Description: 

rmmod does not return failure when module unload fails (at least it does
not on my system).

The syscall() returned a non zero value but a positive one, while rmmod
checks only for negative values.

As the insmod code use syscall() in quite the same way and checks for non
zero, I guess it is a mistake.

Attached trivial patch to fix this.

====================================================================== 

---------------------------------------------------------------------- 
 landley - 12-14-05 19:54  
---------------------------------------------------------------------- 
svn 12836 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-04-05 12:37  mbizon         New Issue                                    
10-04-05 12:37  mbizon         Status                   new => assigned     
10-04-05 12:37  mbizon         Assigned To               => BusyBox         
10-04-05 12:37  mbizon         File Added: rmmod_syscall_ret.patch              
     
12-14-05 19:54  landley        Status                   assigned => closed  
12-14-05 19:54  landley        Note Added: 0000771                          
======================================================================