/networking/udhcp/dhcpc.c is not comletely RFC-3442 complaint

[Mustafa Albayati]

package: busybox
version: 1.36.1

Busybox DHCP client is RFC-3442 (option 121) compliant according to the documentations. However, it's stated under section "DHCP Client Behavior" that

"
 DHCP clients that support this option and send a parameter request
   list MAY also request the Static Routes option, for compatibility
   with older servers that don't support Classless Static Routes.  The
   Classless Static Routes option code MUST appear in the parameter
   request list prior to both the Router option code and the Static
   Routes option code, if present.
"This requirement is currently not fulfilled. Instead, the "add_client_options" function pulls the options from the struct in common.c, in the same order as they are defined. Placing option 121 further down. The patch attached to this email solves this issue by modifying the placement of the option while generating the request section in the "add_client_options" function. As this ordering requirement is only true when option 121 is selected, I choose to not modify the order in the struct. Aside from the risk of breaking other functionality.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20231006/261e31c8/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rfc3442-compliant-option-list-ordering.patch
Type: text/x-patch
Size: 911 bytes
Desc: rfc3442-compliant-option-list-ordering.patch
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20231006/261e31c8/attachment-0001.bin>