[PATCH] Fix non-Linux builds

[tito]

On Sun, 16 Oct 2022 15:44:23 +0200
Samuel Thibault <samuel.thibault at ens-lyon.org> wrote:

> tito, le dim. 16 oct. 2022 09:26:27 +0200, a ecrit:
> > On Sun, 16 Oct 2022 02:04:59 +0200
> > Samuel Thibault <samuel.thibault at ens-lyon.org> wrote:
> > 
> > > Various tools are Linuxish and should thus only attempted to build on
> > > Linux only. Some features are also Linux-only.
> > 
> > Hi,
> > just out of curiosity why can this not be fixed by simply
> > creating a config file that disables the applets that are not relevant 
> > for your platform?
> 
> Because it'd mean making *each and every* downstream (the various BSD
> distributions, the couple Hurd distributions, BeOS, etc. etc.) have to
> determine that list, while it could just be shared upstream, as all
> software usually just do.

Hi,
they still need to got through the config file creation
at least once to enable what is needed for their specific use
so it seems not to make that big difference.

> > I think this would reduce the size of the patch to the
> > #ifdef O_DIRECT part which could be moved for example
> > to include/platform.h.
> 
> Why moving it to platform.h? #ifdef O_DIRECT already means what it
> means.

Couldn't it be achieved by disabling ENABLE_FEATURE_DD_IBS_OBS in config
avoiding an ifdef hell?

Ciao,
Tito

> Ron Yorston, le dim. 16 oct. 2022 08:36:21 +0100, a ecrit:
> > PLATFORM_LINUX was removed a couple of years ago by commit 5c69ad0ec
> > (build system: drop PLATFORM_LINUX).
> > 
> > It had very little effect back then, now it has none.
> 
> Ah, so how would it have to be done nowadays?
> 
> Samuel
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox