[PATCH v8] seedrng: import SeedRNG utility for kernel RNG seed files

Jason A. Donenfeld Jason at zx2c4.com
Tue Apr 12 19:07:36 UTC 2022


Hi Bernhard,

On Tue, Apr 12, 2022 at 8:37 PM Bernhard Reutner-Fischer
<rep.dot.nop at gmail.com> wrote:
>
> Hi Jason!
> I'm a bit surprised that even if i give -n the seed is moved to
> seed.credit. The next boot/run will find the now creditable seed and
> happily add it, IIUC, despite i wanted it to not be credited?
> Is this intentional?

Yes. You misunderstand the purpose of the utility. It creates a
creditable seed when the kernel is able to produce safe random
numbers. In that case, the creditability or non-creditability of the
previous seed does not matter.

>
> PPS: I'm attaching some fiddle on top of your v8 which would give a
> relative savings of

I'm not _super_ comfortable with all of these, and I don't know if I
feel good about attaching them to the original commit. At this
late-stage of golfing, we really risk introducing excessively brittle
code and bringing along new bugs with it. These additional strokes
need to be considered very carefully and individually. So I think at
this point, I'm done on the green, and I think what you ought to do is
commit my v8, and then send your patches as a series, and I'll take
the time to look very carefully at each one individually and comment
on them. And by keeping those as separate commits, if we both do miss
something, it'll be easier to revert and for others to notice the
error too. Does that plan sound okay to you? Commit v8, and then tee
off a new golfing series?

Jason


More information about the busybox mailing list