[PATCH 3/4] Don't use bb_lookup_port() for well known ports

Denys Vlasenko vda.linux at googlemail.com
Thu Sep 9 19:50:20 UTC 2021


On Wed, Aug 25, 2021 at 10:15 PM Sergey Ponomarev <stokito at gmail.com> wrote:
> The bb_lookup_port() function may resolve port by its name.
> But for FTP or TFTP no any names are expected because they work only with one protocol.
> E.g. it doesn't make any sense to execute ftpget -P http.

This change does not improve anything, right?
Only removes some possibilities.

> All other programs like traceroute are just use xatou16().

# busybox traceroute -p ntp -n 192.168.1.1
traceroute: invalid number 'ntp'

But it looks like it should do this. Fedora:

# traceroute -p ntp -n 192.168.1.1
traceroute to 192.168.1.1 (192.168.1.1), 30 hops max, 60 byte packets
 1  192.168.1.1  3.244 ms  3.208 ms  3.194 ms

# traceroute --version
Modern traceroute for Linux, version 2.1.0


More information about the busybox mailing list