[PATCH] vi: add expandtab option

[Bernhard Reutner-Fischer]

On Fri, 16 Apr 2021 15:50:49 +0100
Ron Yorston <rmy at pobox.com> wrote:

> Peter0x44 wrote:
> >> I've haven't signed off on them because I'd like to get a signoff from
> >> Peter on the first  
> >I'm a little confused on what I'm being asked here - should I just
> >submit the patch again, with my git user.name changed to two words and
> >adding the bloatcheck? I see you've done some good changes here, and I'm
> >not sure whether the traffic of sending the patch again is needed.
> >
> >Or is this some legal matter with authorship, the DCO or whatever it's
> >called.  
> 
> It's both, I think.  There's an issue with BusyBox's git being configured
> to require names to consist of two words.  And the Signed-off-by line
> is needed to confirm that you're OK with the DCO.

We require real authorship of patches to make sure the code that is
accepted into the repository is allowed to be submitted under the
license stated in the file or the whole package.

For reasoning see also
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
---8<---
Developer’s Certificate of Origin 1.1
By making a contribution to this project, I certify that:

The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

then you just add a line saying:

Signed-off-by: Random J Developer <random at developer.example.org>
using your real name (sorry, no pseudonyms or anonymous contributions.) This will be done for you automatically if you use git commit -s. Reverts should also include “Signed-off-by”. git revert -s does that for you.

---8<---

This is to avoid situations where you as a person do not accept the
license but submit patches anyway, pretending you were not aware of the
license (GPL in the case of busybox) or if you create patches in your
work-time (either knowingly or by bad luck) and submit them, but your
employer would or does object to give away code you produce during work
hours under the GPL.

thanks for your understanding,