[PATCH] mkdtemp: proper error detection on mktemp

[Alexander Dahl]

Hei hei,

Am Donnerstag, 3. Dezember 2020, 23:42:24 CET schrieb Xabier Oneca -- xOneca:
> On error, mktemp returns an empty string, not NULL.
> 
> Signed-off-by: Xabier Oneca <xoneca at gmail.com>
> ---
>  libbb/platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libbb/platform.c b/libbb/platform.c
> index 03bbb798..187670a8 100644
> --- a/libbb/platform.c
> +++ b/libbb/platform.c
> @@ -107,7 +107,7 @@ void* FAST_FUNC memrchr(const void *s, int c, size_t n)
>  /* This is now actually part of POSIX.1, but was only added in 2008 */
>  char* FAST_FUNC mkdtemp(char *template)
>  {
> -    if (mktemp(template) == NULL || mkdir(template, 0700) != 0)
> +    if (mktemp(template)[0] == '\0' || mkdir(template, 0700) != 0)
>          return NULL;
>      return template;
>  }

Acked-by: Alexander Dahl <ada at thorsis.com>

Greets
Alex