AW: [PATCH] add paste implementation

dietmar.schindler at manroland-web.com dietmar.schindler at manroland-web.com
Mon Mar 13 06:54:17 UTC 2017


> Von: walter harms
> Gesendet: Samstag, 11. März 2017 11:05
>
> Am 10.03.2017 19:07, schrieb Maxime Coste:
> > ...
> > +for (int i = 0; i < file_count; ++i) {
>
> IMHO it is better to put 'int i' in the definition section and remove the int here.
> It make things harder to read (for me), same for the other locations.

Better put the definition of a variable near its use than at a place sometimes far above, requiring to jump or scroll back to see it. And 'for' loop initial declarations were added to the C standard nearly two decades ago for a reason.
--
Regards,
Dietmar Schindler
________________________________
manroland web systems GmbH -- Managing Director: Alexander Wassermann
Registered Office: Augsburg -- Trade Register: AG Augsburg -- HRB-No.: 26816 -- VAT: DE281389840

Confidentiality note:
This eMail and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the intended recipient, you are hereby notified that any use or dissemination of this communication is strictly prohibited. If you have received this eMail in error, then please delete this eMail.
________________________________


More information about the busybox mailing list