[PATCH 1/3] Fix allnoconfig that ash is built in by default.

Denys Vlasenko vda.linux at googlemail.com
Wed Jan 4 11:01:41 UTC 2017


On Wed, Jan 4, 2017 at 1:55 AM, Kang-Che Sung <explorer09 at gmail.com> wrote:
> Change the config order that SH_IS_* and BASH_IS_* will be prompted
> after ASH and HUSH. And if CONFIG_ASH=n, SH_IS_* choice will default to
> SH_IS_NONE.

Try "make config" without any .config file.

With this patch, if I answer "no" to ASH, then all ash config options
_are skipped_, and then I can specify that "sh" is ash.
But I can't configure ash features, since they are skipped already
(config system silently sets them to defaults).

This problem did not exist before the patch.

> Signed-off-by: Kang-Che Sung <explorer09 at gmail.com>
> ---
>  shell/Config.src | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/shell/Config.src b/shell/Config.src
> index 7f5f67050..794f9985a 100644
> --- a/shell/Config.src
> +++ b/shell/Config.src
> @@ -5,10 +5,12 @@
>
>  menu "Shells"
>
> +INSERT
>
>  choice
>   prompt "Choose which shell is aliased to 'sh' name"
> - default SH_IS_ASH
> + default SH_IS_ASH if ASH
> + default SH_IS_NONE

Your mail agent mangles the patch (tabs->spaces).


More information about the busybox mailing list