[PATCH] miscutils/microcom: Fixed segfault

[Denys Vlasenko]

On Thu, Aug 3, 2017 at 7:11 AM, Marian Buschsieweke
<marian.buschsieweke at ovgu.de> wrote:
> microcom did not check if required parameter TTY is present. Thus,
> bb_basename() was called with a NULL pointer if TTY was missing.
> This commit adds the missing check.

Fixed, thanks! (A bit differently)

> ---
>  miscutils/microcom.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/miscutils/microcom.c b/miscutils/microcom.c
> index 14b9f3baf..38f6425c1 100644
> --- a/miscutils/microcom.c
> +++ b/miscutils/microcom.c
> @@ -78,6 +78,11 @@ int microcom_main(int argc UNUSED_PARAM, char **argv)
>  //     argc -= optind;
>         argv += optind;
>
> +       if (*argv == NULL){
> +               bb_show_usage();
> +               return EXIT_FAILURE;
> +       }
> +
>         // try to create lock file in /var/lock
>         device_lock_file = (char *)bb_basename(argv[0]);
>         device_lock_file = xasprintf("/var/lock/LCK..%s", device_lock_file);
> --
> 2.13.3
>
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox