AW: [PATCH] modutils.c: update rmmod message for ENOENT error

[dietmar.schindler at manroland-web.com]

> Von: Maxin B. John
> Gesendet: Donnerstag, 22. Oktober 2015 12:52
>
> When we try to remove a non-existing module:
>
> $ rmmod nonexisting
> rmmod: can't unload 'nonexisting': unknown symbol in module, or unknown
> parameter
>
> man page of "delete_module" says:
> ENOENT: No module by that name exists.
>
> Update the inconsistent message.
>
> Signed-off-by: Maxin B. John <maxin.john at intel.com>
> ---
>  modutils/modutils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modutils/modutils.c b/modutils/modutils.c
> index 84300d9..3acd632 100644
> --- a/modutils/modutils.c
> +++ b/modutils/modutils.c
> @@ -198,7 +198,7 @@ const char* FAST_FUNC moderror(int err)
>       case ENOEXEC:
>               return "invalid module format";
>       case ENOENT:
> -             return "unknown symbol in module, or unknown parameter";
> +             return "no module by that name exists";
>       case ESRCH:
>               return "module has wrong symbol version";
>       case ENOSYS:
> --

Isn't moderror() also possibly called when loading a module? In that case, unfortunately the original message would be right and the updated one wrong.
--
Regards,
Dietmar Schindler
________________________________
manroland web systems GmbH -- Managing Director: Joern Gosse
Registered Office: Augsburg -- Trade Register: AG Augsburg -- HRB-No.: 26816 -- VAT: DE281389840

Confidentiality note:
This eMail and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the intended recipient, you are hereby notified that any use or dissemination of this communication is strictly prohibited. If you have received this eMail in error, then please delete this eMail.

! Please consider your environmental responsibility before printing this eMail !
________________________________