[PATCH v2] blkdiscard: new applet
Ari Sundholm
ari at tuxera.com
Tue Dec 1 12:41:22 UTC 2015
On Mon, 2015-11-30 at 18:32 +0000, Ari Sundholm wrote:
> On Mon, 2015-11-30 at 15:14 +0000, walter harms wrote:
> >
> > Am 30.11.2015 15:52, schrieb Ari Sundholm:
...
> > > + range[0] = offset;
> > > + range[1] = length;
> >
> > Can you discard offset, length ?
> >
>
> Sure, I'll check if that shrinks the applet down a bit.
>
It turns out that eliminating those two variables does not shrink the
busybox executable at all, at least with the toolchain used in my Ubuntu
14.04 system - the bloat-o-meter output is identical, in fact.
Additionally, I find the applet significantly harder to read with this
change. So I'd prefer to leave the two variables as they are if that's
not completely unacceptable.
> Best regards,
> Ari Sundholm
> ari at tuxera.com
>
> > re,
> > wh
> >
> >
> > > + ioctl_or_perror_and_die(fd,
> > > + (opts & OPT_SECURE)
> > > + ? BLKSECDISCARD
> > > + : BLKDISCARD, &range,
> > > + "%s failed",
> > > + (opts & OPT_SECURE)
> > > + ? "BLKSECDISCARD"
> > > + : "BLKDISCARD");
> > > +
> > > + xclose(fd);
> > > +
> > > + return EXIT_SUCCESS;
> > > +}
> > _______________________________________________
> > busybox mailing list
> > busybox at busybox.net
> > http://lists.busybox.net/mailman/listinfo/busybox
>
>
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
More information about the busybox
mailing list