[RFC] new applets: i2c-tools

[AGATE Stephen]

-----Original Message-----
From: Steven Honeyman [mailto:stevenhoneyman at gmail.com] 
Sent: 09 December 2014 17:55
To: Bartosz Golaszewski
Cc: Busybox
Subject: Re: [RFC] new applets: i2c-tools

On 9 December 2014 at 14:51, Bartosz Golaszewski <bartekgola at gmail.com> wrote:
> Hi,
>
> I've started porting i2c-tools to busybox.
>
> This patch implements i2cget together with necessary library functions - a lot
> of this code can be reused in other i2c utils.
>
> Bloatcheck:
>
> function                                             old     new   delta
> i2cget_main                                            -    1464   +1464
> .rodata                                           138898  139779    +881
> packed_usage                                       29706   29825    +119
> i2c_smbus_access                                       -      48     +48
> run_applet_no_and_exit                               588     596      +8
> err_msg_and_usage_and_die                              -       8      +8
> applet_names                                        2451    2458      +7
> applet_main                                         1428    1432      +4
> applet_nameofs                                       714     716      +2
> ------------------------------------------------------------------------------
> (add/remove: 4/0 grow/shrink: 6/0 up/down: 2541/0)           Total: 2541 bytes
>
> I'd like to get some comments before implementing the rest.

Personally, I see this as bloat. It's not difficult to use the original if you need it:

cd ~/stage
tar -xjf ../downloads/i2c-tools-3.1.1.tar.bz2
cd ~/stage/i2c-tools-3.1.1
make CC=$TARGET-gcc DESTDIR=$SYSROOT prefix=/usr
make CC=$TARGET-gcc DESTDIR=$SYSROOT prefix=/usr install

S.