ftpd authentication

[Tanguy Pruvot]

Here is my final commit about getpwnam (and getpwuid)

https://github.com/CyanogenMod/android_external_busybox/commit/d8482dbecc75c8a94bd15a02fa8844cfea91e6d2

maybe the "_r" functions should be used...
http://unixhelp.ed.ac.uk/CGI/man-cgi?getpwuid+3


2014-08-06 12:19 GMT+02:00 Morten Kvistgaard <MK at pch-engineering.dk>:

> The authentication works great now. And with code from libbb, nice. But
> the change_identity function is conflicting with the chroot.
> Even if you reorder the sequence, the change_identity is still conflicting
> somehow. I have to study it some more, before I can suggest a solution.
> (Besides removing change_identity).
>
>
> > -----Original Message-----
> > From: Denys Vlasenko [mailto:vda.linux at googlemail.com]
> > Sent: 5. august 2014 22:00
> > To: Morten Kvistgaard
> > Cc: busybox at busybox.net
> > Subject: Re: ftpd authentication
> >
> > On Mon, Aug 4, 2014 at 12:38 PM, Morten Kvistgaard <MK at pch-
> > engineering.dk> wrote:
> > > I've attached a patch for adding basic authentication to the ftpd.
> > >
> > > This used to work with version 1.21.1. And walter harms tested it with
> > 1.22.1. And it worked with trunk 3 months ago.
> > >
> > > It doesn't seem to work with the current trunk though?
> > >
> > > The difference lies with "getpwnam" I think. (It's returning NULL on
> > > my Ubuntu.)
> >
> > getpwnam will not be very happy in chroot.
> >
> > I fixed that, and also added actual change of user identity, and
> refactored
> > password check to not duplicate code.
> >
> > Applied to git, please try it now.
> > For example, I'm curious whether people who want _anon_ ftp are unhappy
> > now....
>
>
>
> --
> This message has been scanned for viruses and dangerous content by CronLab
> (www.cronlab.com), and is believed to be clean.
>
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20140806/1f8a3e8c/attachment.html>