[PATCH 1/2] wget: make default timeout configurable, remove a duplicate line

[Tito]

On Sunday 20 October 2013 14:57:44 Denys Vlasenko wrote:
> On Friday 18 October 2013 23:21, Harald Becker wrote:
> > Hi Tito !
> > 
> > IMO you got the best solution, ...
> > 
> > >one more solution without the need to modify scripts is to
> > >create a wrapper to wget:
> > >
> > >#!/bin/sh
> > >busybox wget -T xxx $@
> > 
> > ... except, I would do an exec here:
> > 
> > #!/bin/sh
> > exec busybox wget -T xxx $@
> 
> (bike shed painting fest, can't resist to join)
> 
> Also it's better to expand argumanet properly wrt whitespace -
> use "$@", not $@:
> 
> exec busybox wget -T xxx "$@"

Hi,
but even using "$@" whitespace in a URL must be correctly escaped or it will not work with busybox wget
and with real wget.

Busybox wget with wrapper and "$@"  and URL  escaped:

./wget -c ftp://192.168.1.1/STORE_N_GO/test/Text\ File.txt
Connecting to 192.168.1.1 (192.168.1.1:21)
Text File.txt        100% |******************************************************************|     2  --:--:-- ETA


Busybox wget with wrapper and "$@" and URL not escaped:
 
./wget ftp://192.168.1.1/STORE_N_GO/test/Text File.txt
Connecting to 192.168.1.1 (192.168.1.1:21)
wget: bad response to RETR: 550 Failed to open file.


Ciao,
Tito