[PATCH 1/2] Makefile.custom: factorize "make release"

[walter harms]

Am 02.11.2013 22:55, schrieb Denys Vlasenko:
> On Thursday 31 October 2013 21:33, Antony Pavlov wrote:
>> Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
>> ---
>>  Makefile.custom | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/Makefile.custom b/Makefile.custom
>> index 3561e57..d6fe6ae 100644
>> --- a/Makefile.custom
>> +++ b/Makefile.custom
>> @@ -60,25 +60,25 @@ check test: busybox busybox.links
>>  	bindir=$(objtree) srcdir=$(srctree)/testsuite \
>>  	$(SHELL) -c "cd $(objtree)/testsuite && $(srctree)/testsuite/runtest $(if $(KBUILD_VERBOSE:0=),-v)"
>>  
>> +BBVERSIONNAME=busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)
>>  .PHONY: release
>>  release: distclean
>>  	cd ..; \
>> -	rm -r -f busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION); \
>> -	cp -pPR busybox busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION) && { \
>> -	find busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)/ -type d \
>> +	rm -r -f $(BBVERSIONNAME); \
>> +	cp -pPR busybox $(BBVERSIONNAME) && { \
>> +	find $(BBVERSIONNAME)/ -type d \
>>  		-name .svn \
>>  		-print \
>>  		-exec rm -r -f {} \; ; \
>> -	find busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)/ -type d \
>> +	find $(BBVERSIONNAME)/ -type d \
>>  		-name .git \
>>  		-print \
>>  		-exec rm -r -f {} \; ; \
>> -	find busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)/ -type f \
>> +	find $(BBVERSIONNAME)/ -type f \
>>  		-name .\#* \
>>  		-print \
>>  		-exec rm -f {} \; ; \
>> -	tar -czf busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION).tar.gz \
>> -		busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)/ ; }
>> +	tar -czf $(BBVERSIONNAME).tar.gz $(BBVERSIONNAME)/ ; }
>>  
>>  .PHONY: checkhelp
>>  checkhelp:
> 
> I don't see a need for this.


readability ?
IMHO it shrinks the lines very well and make the code much better to read.

re,
 wh