[PATCH] mount: fix check for if the flag should set or clear bits

richard.maw at codethink.co.uk richard.maw at codethink.co.uk
Fri Jun 22 12:58:32 UTC 2012


From: Richard Maw <richard.maw at codethink.co.uk>

Changing the flags type to unsigned long broke this.
Casting the flags to signed for the check works.
---
 util-linux/mount.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/util-linux/mount.c b/util-linux/mount.c
index 220a4e6..9794574 100644
--- a/util-linux/mount.c
+++ b/util-linux/mount.c
@@ -467,7 +467,7 @@ static unsigned long parse_mount_options(char *options, char **unrecognized)
 		for (i = 0; i < ARRAY_SIZE(mount_options); i++) {
 			if (strcasecmp(option_str, options) == 0) {
 				unsigned long fl = mount_options[i];
-				if (fl < 0)
+				if (((long)fl) < 0)
 					flags &= fl;
 				else
 					flags |= fl;
-- 
1.7.5.4



More information about the busybox mailing list