Regression in ash (crashing)

[Vladislav Grishenko]

Hi Denys, Rich

Before 4ba6c5d3ba3d2c7922aff6b5c2e73b8325f1cf17 expfname pointer was never
freed. 
But after, under some circumstances expfname pointer contains garbage due
copynode() doesn't handle it yet.
Trivial fix attached, or different option would be to move that field out
from nfile struct. 

Best Regards, Vladislav Grishenko


> -----Original Message-----
> From: busybox-bounces at busybox.net [mailto:busybox-
> bounces at busybox.net] On Behalf Of Rich Felker
> Sent: Wednesday, December 12, 2012 10:22 AM
> To: busybox at busybox.net
> Subject: Regression in ash (crashing)
> 
> This commit seems to have broken ash, causing some sort of memory
> corruption:
> 
> http://git.busybox.net/busybox/commit/shell/ash.c?id=4ba6c5d3ba3d2c792
> 2aff6b5c2e73b8325f1cf17
> 
> I don't know of a self-contained test case, but musl's configure script is
> crashing. Reverting this commit makes it work again.
> 
> Rich
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bb-fix-redir.patch.patch
Type: application/octet-stream
Size: 650 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20121212/1869c4c9/attachment.obj>