Suggestion: increate username buffer size in login.c

Dmitry Golubovsky golubovsky at gmail.com
Tue Aug 14 17:27:33 UTC 2012


Hi,

There is currently in loginutils/login.c, line 37

enum {
        TIMEOUT = 60,
        EMPTY_USERNAME_COUNT = 10,
        USERNAME_SIZE = 32,
        TTYNAME_SIZE = 32,
};

May I suggest increase USERNAME_SIZE to 256 at least? I may send a
patch, or due to trivial nature of the change someone of the
maintainers could just do it.

My rationale is: if I want to use busybox login together with PAM
involving authentication against some remote host or domain 32
characters may be just insufficient to hold something like
firstname.lastname at auth.example.com (already 36 characters).

Where did the 32 char limit come from?

Thanks.

-- 
Dmitry Golubovsky

Anywhere on the Web


More information about the busybox mailing list