[PATCH] implement groups applet (v3)

Tito farmatito at tiscali.it
Wed Jun 22 06:06:28 UTC 2011



On Wednesday 22 June 2011 04:18:32 Denys Vlasenko wrote:
> On Wednesday 22 June 2011 01:03, Tito wrote:
> > > Applied, thanks!
> > 
> > Hi Denys,
> > i suspect that:
> > 
> > opt_complementary = "?1:u--g:g--u:G--u:u--G:g--G:G--g:r?ugG:n?ugG"
> > 
> > should be before
> > 
> > if (ENABLE_GROUPS && (!ENABLE_ID || applet_name[0] == 'g')) {
> >  option_mask32 = opt = getopt32(argv, "") | JUST_ALL_GROUPS | NAME_NOT_NUMBER;
> > } else {
> > 
> > as else the max args (= 1) statement is not enforced for groups.
> > At least something like this is needed:
> 
> coreutils groups can take more than one arg.
> 
Hi,
Yes, but id doesn't and our groups doesn't.  Even bb's groups' help text says [USER].

Ciao,
Tito


More information about the busybox mailing list