[HELP] Hush problem after update to 1.18.1

Denys Vlasenko vda.linux at googlemail.com
Fri Jan 7 14:14:43 UTC 2011


On Thu, Jan 6, 2011 at 3:06 AM, Bob Liu <lliubbo at gmail.com> wrote:
>> Please post your .config
>>
>
> Attached, Thanks !

Indeed it's a new bug. Thankfully, it's harmless.
I added the fix to
http://busybox.net/downloads/fixes-1.18.1/busybox-1.18.1-hush.patch
it is in this hunk:

 				if (IS_NULL_CMD(ctx.command)
 				 && dest.length == 0 && !dest.has_quoted_part
 				) {
-					continue;
+					/* This newline can be ignored. But...
+					 * without the below check, interactive shell
+					 * will ignore even lines with bare <newline>,
+					 * and show the continuation prompt:
+					 * ps1_prompt$ <enter>
+					 * ps2> _   <=== wrong prompt, should be ps1
+					 */
+					struct pipe *pi = ctx.list_head;
+					if (pi->num_cmds != 0)
+						continue;
 				}
 				/* Treat newline as a command separator. */
 				done_pipe(&ctx, PIPE_SEQ);

-- 
vda


More information about the busybox mailing list