[PATCH] gen_build_files.sh: rewrite with sed

Denys Vlasenko vda.linux at googlemail.com
Sun Nov 21 21:10:46 UTC 2010


On Thursday 18 November 2010 00:36, Mike Frysinger wrote:
> > >  exit 0
> > 
> > What's the purpose with that 'exit 0'?  If some or all the above failed,
> > pretend it succeeded (as I don't see errexit is used)?
> 
> ive let it alone.  dont care either way.

Mike, you deleted the comment which explained "why exit 0?":



commit f718e3a0dbe47ed7ed0398fe4461d33c8f69c669
Author: Mike Frysinger <vapier at gentoo.org>
Date:   Tue Nov 16 07:29:12 2010 -0500

...

-# Last read failed. This is normal. Don't exit with its error code:
 exit 0



As you see, the comment is needed - Cristian's email is the evidence.

I am restoring the comment back.

-- 
vda


More information about the busybox mailing list