[PATCH] modutils: Add /proc/cmdline module option parsing support

walter harms wharms at bfs.de
Wed Mar 3 08:56:39 UTC 2010



Denys Vlasenko schrieb:
> On Sunday 28 February 2010 13:48, walter harms wrote:
>> Denys Vlasenko schrieb:
>>> On Saturday 23 January 2010 00:50, Ozan Çağlayan wrote:
>>>> This adds module option parsing support from /proc/cmdline like in
>>>> module-init-tools.
>>>>
>>>> The options passed through /proc/cmdline are always squeezed by the ones
>>>> provided with command line arguments.
>>> Applied a slightly different version based on your code:
>>>
>>> http://git.busybox.net/busybox/commit/?id=3e26d4fa233705f2061b6f296ac2a604e94f508a
>>>
>>> Thanks!
>> There is now a fixed buffer 2048. IMHO that may cause trouble if it changes for whatever reason.
>> perhaps it is more clever to use xmalloc_open_read_close() ? Just in case ?
> 
> Like this?
> 
> http://git.busybox.net/busybox/commit/?id=197202d435bcb3df7268c8fbb66c05ff78e645ac
> 

thx for supporting my paranoia :)

re,
 wh



More information about the busybox mailing list