[PATCH] diff portability fixes

Denys Vlasenko vda.linux at googlemail.com
Thu Feb 4 03:02:08 UTC 2010


On Thursday 04 February 2010 02:03, Matheus Izvekov wrote:
> On 00:12 Thu 04 Feb     , Denys Vlasenko wrote:
> > On Tuesday 02 February 2010 20:22, Dan Fandrich wrote:
> > > The recent rewrite of the diff applet has introduced several unnecessary
> > > C99isms. This patch removes them to improve portability across compilers.
> > 
> > There is a simple bug in the patch:

> What is the story with C99 and busybox? If we are not supposed to use
> it, why do we pass -std=gnu99 to gcc?

I feel Dan is fighting an uphill battle here
(it would be more productive to fix compilers once and for all),
but as long as code does not get uglier or bigger,
patches like his are fine with me.
--
vda


More information about the busybox mailing list