[PATCH] insmod: Do not add a pair of "" around the arguments of the module.
Carmelo AMOROSO
carmelo.amoroso at st.com
Thu Aug 26 04:56:31 UTC 2010
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 8/25/2010 6:29 PM, Denys Vlasenko wrote:
> On Tue, Aug 24, 2010 at 6:01 AM, Carmelo AMOROSO <carmelo.amoroso at st.com> wrote:
>> If there are some spaces in the insmod command line, then
>> this will be splitted in single words as separate elements of
>> argv. It just needs to chain them together in the options string
>> passed to the sys_init_module syscall.
>
Hi Denis,
> Well, apparently there was a reason why it was done like this.
> I guess old versions of module-init-tools did it too.
>
> I added a comment which says _what version_ of module-init-tools
> is observed to not quote params.
>
good idea
> Applied, thanks!
thanks,
Carmelo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkx18/8ACgkQoRq/3BrK1s/biQCg7mSGqsphnyGVIlXzZc7a4mmm
qH4AoML7cyBGBTqkMSt1QEhz+C6yeAo1
=dSIE
-----END PGP SIGNATURE-----
More information about the busybox
mailing list