bb login.c

[Denys Vlasenko]

On Saturday 31 January 2009 18:37, walter harms wrote:
> Hi Denis,
> i have broken down my patch to login.c into several pieces (4).
> Shall i send the diff or the .c ?

Please send diffs

> can i ping about ionice again again ? It is simply and 2.6 only.

Quality of code is still low.

For example, analyze what happens with variable "pid".
It will end up uninitialized if -p is not given,
and you will set ioprio to some random process.

Did you test "ioprio -c 1 -n 1 sleep 999"? Did you notice
that prio is not set correctly because of the above?

I cleaned the applet up, tested and applied it to svn.
I am asking you to test your code better.
--
vda