problems with modprobe on kernel 2.4

[Denys Vlasenko]

On Monday 06 April 2009 02:54, Guenter wrote:
> Hi,
> resend corrected patch because I missed to move the uts var declaration
> also inside the ifdef block.
> 
> Denys Vlasenko schrieb:
> > On Thursday 02 April 2009 00:50, Guenter wrote:
> >> Hi Denys,
> >> Guenter schrieb:
> >> but while reading through the code here some other observasions/questions:
> >>
> >>     uname(&uts);
> >> is called always directly at beginning although the uts struct is only
> >> used within '#if ENABLE_FEATURE_INSMOD_VERSION_CHECKING/#endif' --
> >> shouldnt we move it just inside the #if block?
> >>
> >> I think same applies to m_has_modinfo too:
> >>     m_has_modinfo = (get_modinfo_value(f, "kernel_version") != NULL);
> >> is just before the #if block where it is used...
> >>
> >> if the feature ENABLE_FEATURE_INSMOD_VERSION_CHECKING is disabled then
> >> these calls are wasted cpu cycles...
> > 
> > Feel free to send a patch which fixes this.
> ok, here's the follow-up patch against recent svn - attached.

Applied, thanks!
--
vda