runsvdir: shrink

Denys Vlasenko vda.linux at googlemail.com
Mon Sep 22 21:35:18 UTC 2008


On Monday 22 September 2008 17:01, dronnikov at gmail.com wrote:
> * runsvdir used to periodically log timestamps.
> Now it is made FEATUREd: -500 bytes if not used.
> 
> Please, consider applying.

+config FEATURE_RUNSVDIR_LOG
+       bool "Enable periodic timestamp logging"
+       depends on RUNSVDIR
+       default n
+       help
+         Weird badly documented feature.

Then document it better.


+USE_FEATURE_RUNSVDIR_LOG (
+#      define rplog     (G.rplog     )
+#      define rploglen  (G.rploglen  )
+#      define logpipe   (G.logpipe   )
+#      define pfd       (G.pfd       )
+#      define stamplog  (G.stamplog  )
+)

I did not even test whether it works this way, it violates C standard.


+                               pfd.fd = logpipe.rd;
+                               pfd.events = POLLIN;

Compile error. Did you compile test FEATURE_RUNSVDIR_LOG=y?

Applied after fixing these.
--
vda



More information about the busybox mailing list