multiple-cpu aware procps Top

[Vineet Gupta]

On Thu, Sep 18, 2008 at 4:47 PM, Denys Vlasenko <vda.linux at googlemail.com>wrote:

> > ===========================
> > The summary of changes is:
> > ===========================
> >
> > 1. Process List output has an additional column "cpu" which reports last
> CPU
> > the process was found running on (when /proc sample was taken). This can
> > come in handy to observe
> > the effects of calls such as sched_setaffinity( ) which can pin a task to
> a
> > set of CPU(s). New Config option ENABLE_FEATURE_TOP_SMP_PROCESS
> >
> > 2. CPU Utilization reporting per CPU. There is a toggle "1" to display
> the
> > regular output which is aggregate of all CPUs) vs a  per CPU line. New
> > Config option ENABLE_FEATURE_TOP_SMP_CPU
> >
> > Please consider applying the attached patch.
>
> Please use only tabs for indentation, the patch you attached
> has it mixed (tabs/spaces):
>

Sorry for the goof up. Find attached the patch with consistent Tabs
(hopefully I've taken care of all of them) and some minor comment changes.


>
> +#if ENABLE_FEATURE_TOP_SMP_PROCESS
> +                               /* (6): rss_rlim, start_code, end_code,
> start_stack, kstk_esp, kstk_eip */
> +                               /* (4): signal, blocked, sigignore,
> sigcatch */
> +                               /* (4): wchan, nswap, cnswap, exit_signal
> */
> +                       cp = skip_fields(cp, 14);
> +            sp->last_seen_on_cpu = fast_strtoul_10(&cp);
>  #endif
>
> Otherwise, looks good.
> --
> vda
>


Thanks,
Vineet
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.busybox.net/pipermail/busybox/attachments/20080918/42f0e65f/attachment-0002.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: top-smp-patch2.diff
Type: text/x-patch
Size: 16766 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20080918/42f0e65f/attachment-0002.bin