setfont/kbd_mode - which console?

[Roy Marples]

Denys Vlasenko wrote:
> On Tuesday 04 November 2008 16:03, Roy Marples wrote:
>> On Tuesday 04 November 2008 14:58:30 Roy Marples wrote:
>>> So, in an attempt yet again to get OpenRC to boot cleanly using busybox
>>> here's a patch that enables -C device for kbd_mode and setfont. The patch
>>> is done so extending similar support for other console tools is fairly
>>> trivial.
> 
> setfont has it already:

So it has.
My bad for not checking svn.

> As for kbd_mode, googling for "man kbd_mode" shows that kbd_mode
> has no -C option. I am somewhat opposed to adding our own
> options. This OpenRC thing - does it really use "kbd_mode -C TTY"?
> What is their kbd_mode (what "kbd_mode --version"
> and "kbd_mode --help" say)?

Yes, it uses kbd_mode -C TTY
It's not in the man page, but it is in the sources.
It does not support any long options, but the package is kbd-1.14.1

> OTOH, logically, -C TTY makes sense for kbd_mode, loadkmap...

Well, I just care about kbd_mode :)

This new patch applies a similar fix for setfont to kbd_mode.
This deviates from the upstream variant of "find a console fd" when -C
is not given, but this works for all real world scenarios I can think of.

uberpc busybox-1.12.1 # ./scripts/bloat* ../*orig/busybox ./busybox
function                                             old     new   delta
kbd_mode_main                                        245     275     +30
packed_usage                                       24130   24147     +17
static.KD_xxx                                          5       7      +2
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/0 up/down: 49/0)               Total: 49
bytes

Thanks

Roy
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kbd_mode.diff
Url: http://busybox.net/lists/busybox/attachments/20081108/12bea77a/attachment.txt