[patch] coreutils/printf.c

Denys Vlasenko vda.linux at googlemail.com
Sat May 31 11:28:44 PDT 2008


On Saturday 31 May 2008 19:10, Cristian Ionescu-Idbohrn wrote:
> On Sat, 31 May 2008, Denys Vlasenko wrote:
> > This one does not seem right too:
> >
> > -USE_PRINTF(APPLET(printf, _BB_DIR_USR_BIN, _BB_SUID_NEVER))
> > +USE_PRINTF(APPLET_NOFORK(printf, printf, _BB_DIR_USR_BIN, _BB_SUID_NEVER, printf))
> 
> Hmm...  I must be blind :( Can't see it :(  What's wrong?  Compare to this
> (some lines above in include/applets.h):
> 
> USE_DIRNAME(APPLET_NOFORK(dirname, dirname, _BB_DIR_USR_BIN, _BB_SUID_NEVER, dirname))

I meant that if you made it NOFORK (chunk #1) then you must not exit (chunk #2).
Chunk #1 is ok if you fixed chunk #2.
--
vda


More information about the busybox mailing list