[PATCH] minor fix for modprobe.conf blacklist feature

Natanael Copa natanael.copa at gmail.com
Wed May 21 13:36:48 PDT 2008


Hi,

The patch makes the order of the alias/blacklist in modprobe.conf 
irrelevant (like module-utils' modprobe). In first patch the alias had 
to be defined before the blacklist which caused problems because the 
modprobe.conf file is read before /lib/modules/*/modules.alias.

The attatched patch will mark the blacklisted module itself rather than 
trying to find the alias that points to the blacklisted module and test 
this flag later in the alias resolving stage.

It also reduces size (x86 glibc gcc-4):

function                                             old     new   delta
check_de                                             354     352      -2
include_con                                          911     902      -9
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-11)             Total: -11 
bytes
   text       data        bss        dec        hex    filename
  10729        401       8268      19398       4bc6    busybox_old
  10718        401       8268      19387       4bbb    busybox_unstripped

It also opens for futher size optimization as there are several loops 
that either strcmp(dt->m_name, mod) or check_pattern(dt->m_name, mod) 
that could be collected in a function.

Thanks!

-nc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: modprobe-blacklist-fix.patch
Type: text/x-patch
Size: 917 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20080521/29cadb98/attachment.bin 


More information about the busybox mailing list