svn commit: trunk/busybox

[Bernhard Fischer]

On Thu, May 15, 2008 at 02:44:46PM -0700, vda at busybox.net wrote:
>Author: vda
>Date: 2008-05-15 14:44:46 -0700 (Thu, 15 May 2008)
>New Revision: 21984
>
>Log:
>Add more -W options to gcc.
>
>
>
>Modified:
>   trunk/busybox/Makefile.flags
>
>
>Changeset:
>Modified: trunk/busybox/Makefile.flags
>===================================================================
>--- trunk/busybox/Makefile.flags	2008-05-15 21:30:45 UTC (rev 21983)
>+++ trunk/busybox/Makefile.flags	2008-05-15 21:44:46 UTC (rev 21984)
>@@ -21,27 +21,16 @@
> CFLAGS += $(call cc-option,-Wall -Wshadow -Wwrite-strings,)
> CFLAGS += $(call cc-option,-Wundef -Wstrict-prototypes,)
> CFLAGS += $(call cc-option,-Wunused -Wunused-parameter,)
>-# If you want to add "-Wmissing-prototypes -Wmissing-declarations" above
>-# (or anything else for that matter) make sure that it is still possible
>-# to build bbox without warnings. Current offender: find.c:alloc_action().
>-# Looks more like gcc bug: gcc will warn on it with or without prototype.
>-# But still, warning-free compile is a must, or else we will drown
>-# in warnings pretty soon.
>+CFLAGS += $(call cc-option,-Wmissing-prototypes -Wmissing-declarations,)
>+# If you want to add more -Wsomething above, make sure that it is
>+# still possible to build bbox without warnings.
> 
> ifeq ($(CONFIG_WERROR),y)
> CFLAGS += $(call cc-option,-Werror,)
>-else
>-# for development, warn a little bit about unused results..
>-CPPFLAGS += -D_FORTIFY_SOURCE=2

Why did you remove fortify source? IIRC this was initially wrapped in
CONFIG_DEBUG, fwiw.