[patch] bbsplash

[Bernhard Fischer]

On Wed, Mar 26, 2008 at 02:18:56PM +0100, Denys Vlasenko wrote:
>On Tuesday 25 March 2008 08:47, Michele Sanges wrote:

>diff -d -urpN busybox.0/include/applets.h busybox.1/include/applets.h
>--- busybox.0/include/applets.h	2008-03-24 15:42:09.000000000 +0100
>+++ busybox.1/include/applets.h	2008-03-26 10:43:48.000000000 +0100
>@@ -149,6 +149,7 @@ USE_EXPR(APPLET(expr, _BB_DIR_USR_BIN, _
> USE_FAKEIDENTD(APPLET(fakeidentd, _BB_DIR_USR_SBIN, _BB_SUID_NEVER))
> USE_FALSE(APPLET_NOFORK(false, false, _BB_DIR_BIN, _BB_SUID_NEVER, false))
> USE_FBSET(APPLET(fbset, _BB_DIR_USR_SBIN, _BB_SUID_NEVER))
>+USE_FBSPLASH(APPLET(fbsplash, _BB_DIR_BIN, _BB_SUID_NEVER))

Perhaps it would make more sense to put this into /sbin ?

> USE_FDFLUSH(APPLET_ODDNAME(fdflush, freeramdisk, _BB_DIR_BIN, _BB_SUID_NEVER, fdflush))
> USE_FDFORMAT(APPLET(fdformat, _BB_DIR_USR_BIN, _BB_SUID_NEVER))
> USE_FDISK(APPLET(fdisk, _BB_DIR_SBIN, _BB_SUID_NEVER))

>diff -d -urpN busybox.0/libbb/lineedit.c busybox.1/libbb/lineedit.c
>--- busybox.0/libbb/lineedit.c	2008-03-24 15:42:06.000000000 +0100
>+++ busybox.1/libbb/lineedit.c	2008-03-26 12:12:04.000000000 +0100
[]
Denis, this is unrelated, please apply separately.

>diff -d -urpN busybox.0/miscutils/fbsplash.c busybox.1/miscutils/fbsplash.c
>--- busybox.0/miscutils/fbsplash.c	1970-01-01 01:00:00.000000000 +0100
>+++ busybox.1/miscutils/fbsplash.c	2008-03-26 14:08:04.000000000 +0100
>@@ -0,0 +1,446 @@
>+/* vi: set sw=4 ts=4: */
>+/*
>+ * splash implementation for busybox

s/splash/bootsplash/

>+ *
>+ * Copyright (C) 2008 Michele Sanges <michele.sanges at otomelara.it>,
>+ * <michele.sanges at gmail.it>
>+ *
>+ * Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
>+ *
>+ * Usage:
>+ * - use kernel option 'vga=xxx' or otherwise enable framebuffer device.
>+ * - put somewhere the fbsplash.ini file and image in .ppm format.

s/\.ini/\.cfg/;# We're not on windows, we have configuration files

[]
As said previously, it may be benefical to pass a pointer to struct
geometry to the drawing functions instead of passing x/y and eventually
r/g/b/a as individual parameters.

>diff -d -urpN busybox.0/miscutils/fbsplash.ini busybox.1/miscutils/fbsplash.ini
>--- busybox.0/miscutils/fbsplash.ini	1970-01-01 01:00:00.000000000 +0100
>+++ busybox.1/miscutils/fbsplash.ini	2008-03-26 14:06:45.000000000 +0100

Please rename to .cfg

thanks,