BB vi bug

Denys Vlasenko vda.linux at googlemail.com
Sat Jun 21 20:35:19 UTC 2008


On Saturday 21 June 2008 16:04, walter harms wrote:
> 
> Since text_hole_make() does not return NULL anymore this function can be simplified also;
> btw: since text_hole_make(p,x) never changes p it could become void.

This will necessitate p++ at each callsite.

> #if ENABLE_FEATURE_VI_YANKMARK \
>  || (ENABLE_FEATURE_VI_COLON && ENABLE_FEATURE_VI_SEARCH) \
>  || ENABLE_FEATURE_VI_CRASHME
> static char *string_insert(char * p, char * s) // insert the string at 'p'
> {
> 	int cnt, i;
> 
> 	i = strlen(s);
> 	if (text_hole_make(p, i)) {
> 		strncpy(p, s, i);

I simplified it, thanks!
--
vda



More information about the busybox mailing list