[PATCH] print_flags() take 2: -644 bytes

[Denys Vlasenko]

On Saturday 07 June 2008 14:47, Natanael Copa wrote:
> So I collected the ideas/suggestions and prepared another set of patches.
> 
> The biggest win is in hdparm, but this time there was a win in both 
> fdisk and arp too so i submit pathes for those too.

Allyesconfig build revealed that there is another print_flags()
already in the tree.

> I grouped the masks array with the labels '\0' separated string into a 
> struct. They are always used together anyway and by grouping them we 
> save one parameter for every call.

Not always. You cheated in hdparm because there one mask is used with
two different labels. Result:

>    text       data        bss        dec        hex    filename
>  135156       2173       4500     141829      22a05    busybox_old
>  134540       2361       4500     141401      22859    busybox_unstripped
                ^^^^ here

It took some effort to bring allyesconfig busybox's
data+bss to fit into 8k on i386.
You grew data by 190 bytes.

I proporse the following variant:

   text    data     bss     dec     hex filename
 810564     624    7060  818248   c7c48 busybox_old
 810002     624    7060  817686   c7a16 busybox_unstripped

See attached. Can you confirm that it works for you too?
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3.patch
Type: text/x-diff
Size: 12270 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20080607/fca820b1/attachment-0001.patch