[PATCH] fsck -A goes into infinite loop and kills all processes

[Roy Marples]

On Thu, 2008-01-31 at 18:17 +0000, Roy Marples wrote:
> On Thu, 2008-01-31 at 12:52 -0500, Paul Fox wrote:
> > > Which isn't good.
> >  > 
> >  > I get "wait: No more child process?!?" a zillion times down the screen,
> >  > hit ctrl-c and then boom, everything dies.
> >  > 
> >  > Debugging is ..... tricky as such and I can't see anything obviously
> >  > wrong.
> > 
> > do you have strace?  try "strace -f -e execve fsck -A".  that may give
> > a clue as to what's being run.
> 
> Ah yes, it's because there is no helper installed for ext4dev. Ensuring
> that all helpers exist fixes the error. So it's not handling exec errors
> correctly. I'll see if I can fix fsck now.

The execute function does not return when pid is <1, so it stores -1 as
a pid to kill, which kills quite a bit really :)

Patch attached to fix.

Thanks

Roy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox-fsck.patch
Type: text/x-patch
Size: 428 bytes
Desc: not available
Url : http://busybox.net/lists/busybox/attachments/20080131/03ac53c0/attachment.bin