resend:PATCH: save a few bytes in arping
Denys Vlasenko
vda.linux at googlemail.com
Fri Apr 25 08:10:38 UTC 2008
On Friday 25 April 2008 09:11, walter harms wrote:
> +static void *cp_step(void *_dst,void *_src, size_t n)
> +{
> + memcpy(_dst, _src, n);
Indentation is inconsistent with the rest of the file.
> +
> + return _dst += n;
Incrementing the pointer of type void* is a gcc'ism.
> ah->ar_op = option_mask32 & ADVERT ? htons(ARPOP_REPLY) : htons(ARPOP_REQUEST);
> + p=cp_step(p, &ME->sll_addr, ah->ar_hln);
Style is not consistent. See how = looks like in preceding line.
- opt_complementary = "=1:Df:AU:c+";
+ // opt_complementary = "=1:Df:AU:c+";
Why did you kill -c option?
--
vda
More information about the busybox
mailing list