Nameif broken

Nico Erfurth masta at perlgolf.de
Wed Apr 9 20:05:08 UTC 2008


Hi,

some months ago I've send a patch to extend the matching capabilities of 
nameif. The patch was modified (in fact broken ;]) and applied.

While testing the latest releases i've found that nameif does not work 
at all anymore, as the /proc/net/dev parsing code and some other things 
were broken.

Appended is a patch to fix nameif, I've also extended the cleanup-code 
to match the new data structure and did some minor code shrinks.

Nico

$ make bloatcheck
function                                             old     new   delta
delete_eth_table                                       -      46     +46
nameif_main                                          721     732     +11
.rodata                                           144518  144523      +5
prepend_new_eth_table                                301     303      +2
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 3/0 up/down: 64/0)               Total: 64 
bytes
    text	   data	    bss	    dec	    hex	filename
  668132	   2568	   9856	 680556	  a626c	busybox_old
  668196	   2568	   9856	 680620	  a62ac	busybox_unstripped

-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox-nameif.patch
Type: text/x-patch
Size: 2825 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20080409/44ddc6e0/attachment-0002.bin 


More information about the busybox mailing list