minor bug in kill

Paul Fox pgf at brightstareng.com
Wed Nov 14 15:41:47 PST 2007


 > On Wednesday 14 November 2007 15:05, Paul Fox wrote:
 > > one of kill's error messages currently goes to stdout.  i'd
 > > simply commit this, because it seems like a trivial change, until
 > > i start looking at all of the code paths through kill_main(),
 > > from the shell builtin, from killall, from killall5, etc.
 > 
 > please do, with small correction (below).
 > 
 > > (also, even if kill can't use bb_show_usage() for this reason, is
 > > there a reason it shouldn't print out something that at least
 > > looks like a usage message?  :-)
 > 
 > Why it can't use bb_show_usage? Won't work as ash builtin?

right.  so i can't convert to the "..._and_die()" form either.

i'll commit my minimal patch.

paul
=---------------------
 paul fox, pgf at brightstareng.com


More information about the busybox mailing list