An initial revision of "kill -l [exitstatus]"
Denis Vlasenko
vda.linux at googlemail.com
Tue May 1 13:09:37 PDT 2007
On Sunday 29 April 2007 23:17, Mats Erik Andersson wrote:
> sön 2007-04-29 klockan 16:35 +0200 skrev Denis Vlasenko:
> > I was thinking of making shared code for entire kill,
> > not just kill -l. This way we can save much more on code size.
> >
> > I am attaching my proposal. Please test & report whereever I goof up
> > (a lot of subtle error cases there - kill_main must be very careful now
> > to not exit, but return to caller!)
>
> The trick of using a space character to parse job numbers is a
> good one, I did not find a work around in order to do the full
> program of integrating both modes of operation into one code.
>
> In a first test run I could not uncover any errors, but I cannot
> agree an the output for the full listing case "kill -l". The SUSv3
> specification gives the implementor his freedom, but I dislike
> a long listing that include explicit numbers like 7, 16, and 22--31,
> which do not correspond to named signals. I attach a patch to
> correct this. Unfortunately it adds, in its present form, 16 bytes.
I am incorporating this into a patch.
Actually, having all 32 signal names included makes code AND signals[]
vector smaller, so we can simply have all of them defined.
But on other libc we still may have gaps, so I will use your check
nevertheless.
Thanks
--
vda
More information about the busybox
mailing list