ver6 (Re: [PATCH 1/8] busybox -- SELinux option support for coreutils: ver3

[Yuichi Nakamura]

Thanks for review!

On Thu, 8 Mar 2007 12:39:42 +0100
Bernhard Fischer <rep.dot.nop at gmail.com> wrote:
> A couple of superfluous newlines for non SElinux were introduced in your
> patch. E.g. just one:
> @@ -1519,7 +1543,10 @@
>         "       -m      Set permission modes\n" \
>         "       -o      Set ownership\n" \
>         "       -p      Preserve date\n" \
> -       "       -s      Strip symbol tables"
> +       "       -s      Strip symbol tables\n" \
> +       USAGE_SELINUX( \
> +       "       -Z      Set security context of copy" \
> +       )
> 
> Please move the newline to the start of the SElinux string everywhere.
Fixed.


> 
> Index: selinux/Config.in
> ===================================================================
> --- selinux/Config.in   (revision 17961)
> +++ selinux/Config.in   (working copy)
> ...
> +         Enable support for chcon command as a SELinux utility.
> 
> as an SELinux utility?
> Also please add a terse description like:
> +	Applet to change the security context
> 
> Same for runcon config entry
Fixed.

Regards,
Yuichi Nakamura



-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox-coreutils-common-01.v6.patch
Type: application/octet-stream
Size: 9000 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20070309/399dfc35/attachment-0001.obj