[PATCH Try#2 3/3] Major improvements to RPM

[Andy Green]

Denis Vlasenko wrote:
> On Saturday 09 June 2007 12:57, andy at warmcat.com wrote:
>> Adds many new features to RPM including a 'database' of installed
>> packages down /var/lib/rpm.  See the comments in rpm.c and the
>> usage help for more information.
>>
>> Signed-off-by: Andy Green <andy at warmcat.com>
> 
> Wow, this is BIG! Thanks.
> 
> Will probably need several iterations of review.

Well, thanks for taking the time to look at it.

>> +	cwd = xmalloc(PATH_MAX);
>> +	getcwd(cwd, PATH_MAX);
> 
> We have xmalloc_getcwd_or_die() which eats much less mem.

It seems to be xrealloc_getcwd_or_warn().

>> +	while ((opt = getopt(argc, argv, "iqpldcr:eofVUaFC:")) != -1) {
> 
> maybe getopt32?

Is there any benefit to getopt32 if there are only two args that can be
filled and there will be a case needed for one them anyway?  Or did I
miss something about it?

-Andy